kobayashi90/WiiMart
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

implement account activity, fix translations and settings page #12

Merged
idkwhere1sthisname merged 20 commits from main into main 2025-03-20 21:11:48 +00:00
Conversation 6 Commits 20 Files changed 12 +1286 -869
idkwhere1sthisname commented 2025-03-17 17:43:58 +00:00 (Migrated from github.com)
Copy link

the account activity page is blank, so its fixed now
translations got fixed by removing "WiiMart" in the recommended titles translations
settings page got fixed by moving the remove account button at the bottom
some strings got the wiiShop class to translate them automatically

the account activity page is blank, so its fixed now translations got fixed by removing "WiiMart" in the recommended titles translations settings page got fixed by moving the remove account button at the bottom some strings got the <code>wiiShop</code> class to translate them automatically
Ocarinaoftime (Migrated from github.com) reviewed 2025-03-17 17:43:58 +00:00
LNLenost (Migrated from github.com) approved these changes 2025-03-18 14:57:05 +00:00
LNLenost (Migrated from github.com) left a comment
Copy link

LGTM! The only thing I thought of is how to translate allat text... is it already translated by Nintendo? Or is there any new text?

LGTM! The only thing I thought of is how to translate allat text... is it already translated by Nintendo? Or is there any new text?
idkwhere1sthisname commented 2025-03-18 15:07:04 +00:00 (Migrated from github.com)
Copy link

"Wii Menu" and "Connecting. Please wait..." should be automatically translated, but everything else isn't

"Wii Menu" and "Connecting. Please wait..." should be automatically translated, but everything else isn't
LNLenost commented 2025-03-18 15:13:00 +00:00 (Migrated from github.com)
Copy link

Auuuugh

Its gonna be long
We should get some type of translation service i.e. weblate

On Tue, Mar 18, 2025, 4:07 PM idkwhereisthisname @.***>
wrote:

"Wii Menu" and "Connecting. Please wait..." should be automatically
translated, but everything else isn't

—
Reply to this email directly, view it on GitHub
https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733596695, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MADEFQFN77XR6BB422L6T2VAZC3AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGU4TMNRZGU
.
You are receiving this because your review was requested.Message ID:
@.***>
[image: idkwhere1sthisname]idkwhere1sthisname left a comment
(WiiMart/WiiMart#12)
https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733596695

"Wii Menu" and "Connecting. Please wait..." should be automatically
translated, but everything else isn't

—
Reply to this email directly, view it on GitHub
https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733596695, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MADEFQFN77XR6BB422L6T2VAZC3AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGU4TMNRZGU
.
You are receiving this because your review was requested.Message ID:
@.***>

Auuuugh Its gonna be long We should get some type of translation service i.e. weblate On Tue, Mar 18, 2025, 4:07 PM idkwhereisthisname ***@***.***> wrote: > "Wii Menu" and "Connecting. Please wait..." should be automatically > translated, but everything else isn't > > — > Reply to this email directly, view it on GitHub > <https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733596695>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/A2MADEFQFN77XR6BB422L6T2VAZC3AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGU4TMNRZGU> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > [image: idkwhere1sthisname]*idkwhere1sthisname* left a comment > (WiiMart/WiiMart#12) > <https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733596695> > > "Wii Menu" and "Connecting. Please wait..." should be automatically > translated, but everything else isn't > > — > Reply to this email directly, view it on GitHub > <https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733596695>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/A2MADEFQFN77XR6BB422L6T2VAZC3AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGU4TMNRZGU> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> >
Denfiko commented 2025-03-18 15:23:18 +00:00 (Migrated from github.com)
Copy link

Don't know if I can be here, but I want to try translating

Don't know if I can be here, but I want to try translating
LNLenost commented 2025-03-18 15:30:50 +00:00 (Migrated from github.com)
Copy link

Dm me on #general in discord: @lnlenost

On Tue, Mar 18, 2025, 4:23 PM Denfiko @.***> wrote:

Don't know if I can be here, but I want to try translating

—
Reply to this email directly, view it on GitHub
https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733657145, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MADEGY2QCAE6XU3X33JCL2VA273AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGY2TOMJUGU
.
You are receiving this because your review was requested.Message ID:
@.***>
[image: Denfiko]Denfiko left a comment (WiiMart/WiiMart#12)
https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733657145

Don't know if I can be here, but I want to try translating

—
Reply to this email directly, view it on GitHub
https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733657145, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MADEGY2QCAE6XU3X33JCL2VA273AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGY2TOMJUGU
.
You are receiving this because your review was requested.Message ID:
@.***>

Dm me on #general in discord: @lnlenost On Tue, Mar 18, 2025, 4:23 PM Denfiko ***@***.***> wrote: > Don't know if I can be here, but I want to try translating > > — > Reply to this email directly, view it on GitHub > <https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733657145>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/A2MADEGY2QCAE6XU3X33JCL2VA273AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGY2TOMJUGU> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > [image: Denfiko]*Denfiko* left a comment (WiiMart/WiiMart#12) > <https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733657145> > > Don't know if I can be here, but I want to try translating > > — > Reply to this email directly, view it on GitHub > <https://github.com/WiiMart/WiiMart/pull/12#issuecomment-2733657145>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/A2MADEGY2QCAE6XU3X33JCL2VA273AVCNFSM6AAAAABZGEIZEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZTGY2TOMJUGU> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> >
Sign in to join this conversation.
Reviewers
No reviewers
Ocarinaoftime
LNLenost
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: kobayashi90/WiiMart#12
No description provided.
Delete branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?