fix tons of linker warnings, mark all uninitialized as so, fix a few issues where uninitialized was due to incorrect decompilation

This commit is contained in:
Rainchus 2024-08-01 13:00:53 -05:00
parent a827b30178
commit 0a152cdcef
16 changed files with 657 additions and 658 deletions

View file

@ -1160,10 +1160,6 @@ void fn_1_4964(ModelData *arg0)
GXColor *var_r19;
var_r30 = arg0->unk_120;
(void)var_f31;
(void)var_f31;
(void)var_f31;
(void)var_f31;
if (var_r30->unk_28) {
if (!omPauseChk()) {
@ -1225,6 +1221,10 @@ void fn_1_4964(ModelData *arg0)
if (var_r28->unk_01) {
var_r25->z = var_r28->unk_10.z - (50.0f * (0.003921569f * (var_r28->unk_08 * var_f31)));
}
(void)var_f31;
(void)var_f31;
(void)var_f31;
(void)var_f31;
}
var_r25++;
var_r21++;
@ -1444,7 +1444,7 @@ void fn_1_6304(ModelData *arg0, Mtx arg1)
void fn_1_64F8(UnkM406Struct2 *arg0)
{
float var_f31;
float var_f31; // ! - uninitialized
UnkM406Struct2 *var_r31;
s32 var_r30;

View file

@ -2018,7 +2018,7 @@ float fn_1_143F4(Vec *arg0, UnkM406PlayerStruct2 *arg1)
Vec sp1C;
Vec sp10;
HsfBuffer *spC;
float sp8;
float sp8; // ! - uninitialized
float var_f31;
float var_f30;

View file

@ -511,10 +511,9 @@ static inline void unkInline(unkStruct4* var_r31, s16 var_r29, s16* var_r28, s16
}
void fn_1_2484(omObjData* object) {
s16 var_r28;
s16 var_r28; // ! - uninitialized
s16 var_r29;
unkStruct4* var_r31;
s32 temp_r27;
var_r31 = &lbl_1_bss_40[0];
object->stat |= 0x100;

View file

@ -1573,7 +1573,7 @@ void fn_1_5554(void) {
float var_f26;
float var_f31;
float var_f30;
float var_f29;
float var_f29; // ! - uninitialized
float sp8;
float temp_f24;
UnkBss138InnerStruct00 spC;

View file

@ -1720,7 +1720,8 @@ void fn_1_6AE8(ModelData *model, ParticleData *particle, Mtx matrix)
HsfanimStruct01 *temp_r31;
s32 temp_r29;
s16 temp_r28;
s32 temp_r27;
s32 temp_r27; // ! - uninitialized
if(!particle->unk_00) {
particle->unk_00 = 1;
temp_r31 = particle->unk_48;

View file

@ -232,7 +232,7 @@ void fn_1_13DC(omObjData *object)
void fn_1_17C0(omObjData *object)
{
s16 sp8;
s16 sp8; // ! - uninitialized
UnkM417Struct *var_r30;

View file

@ -1443,9 +1443,9 @@ void fn_1_485C(ModelData *model, Mtx mtx)
Mtx spA0;
ROMtx sp70;
Mtx sp40;
Vec sp34;
Vec sp28;
Vec sp1C;
Vec sp34; // ! - uninitialized
Vec sp28; // ! - uninitialized
Vec sp1C; // ! - uninitialized
Vec sp10;
float var_f31;

View file

@ -143,7 +143,7 @@ void ClusterMotionExec(ModelData *arg0) {
s16 var_r20;
HsfCluster *temp_r26;
HsfData *temp_r28;
HsfMotion *temp_r27;
HsfMotion *temp_r27; // ! - uninitialized
HsfTrack *var_r31;
HsfTrack *var_r30;
MotionData *var_r23;

View file

@ -964,8 +964,7 @@ static void InitJunction(s32 arg0, s32 arg1, f32 arg8) {
Vec sp5C;
Vec sp50;
Vec sp44;
f32 sp40;
f32 sp3C;
f32 sp3C[2];
s32 sp38;
s16 sp20;
s16 spE;
@ -998,10 +997,10 @@ static void InitJunction(s32 arg0, s32 arg1, f32 arg8) {
temp_r29->field00_bit5 = 0;
temp_r29->unk_01 = 0;
var_r28->scale.x = var_r28->scale.y = var_r28->scale.z = 3.0f;
HuWinMesMaxSizeGet(1, &sp3C, 0x90003);
HuWinMesMaxSizeGet(1, sp3C, 0x90003);
var_f27 = -10000.0f;
var_f28 = 304.0f;
temp_r29->unk_04 = HuWinCreate(var_f27, var_f28, sp3C, sp40, 0);
temp_r29->unk_04 = HuWinCreate(var_f27, var_f28, sp3C[0], sp3C[1], 0);
HuWinBGTPLvlSet(temp_r29->unk_04, 0.0f);
HuWinMesSpeedSet(temp_r29->unk_04, 0);
HuWinMesSet(temp_r29->unk_04, 0x90003);
@ -2847,6 +2846,7 @@ void BoardPlayerCopyEyeMat(s32 arg0, s32 arg1) {
var_r29 = playerMatCopy[arg0];
if (arg1 != 0) {
temp_r28 = &eyeMatTbl[GWPlayer[arg0].character][0];
(void)temp_r28;
for (var_r25 = 0; var_r25 < hsfData->materialCnt; var_r25++, material++, var_r29++) {
var_r24 = 1;
@ -2870,7 +2870,6 @@ void BoardPlayerCopyEyeMat(s32 arg0, s32 arg1) {
}
} else {
memcpy(hsfData->material, var_r29, hsfData->materialCnt * 0x3C);
(void)temp_r28;
}
DCStoreRange(hsfData->material, hsfData->materialCnt * 0x3C);
}

View file

@ -1824,7 +1824,7 @@ s32 CharModelEffectNpcInit(s16 arg0, s16 arg1, s16 arg2, s16 arg3) {
}
s32 CharModelEffectNpcInitSilent(s16 arg0, s16 arg1, s16 arg2) {
s32 sp10;
s32 sp10; // ! - uninitialized
CharModelEffectNpcInit(arg0, arg1, arg2, -1);
return sp10;