Remove certain common headers

common.h fully removed. common_structs.h incorporated into new game/gamework_data.h header along with parts of variables.h (Other parts were moved to more appropriate headers). functions.h split into unsplit.h and board_unsplit.h

include/REL/w10Dll.h

@@ -1,7 +1,10 @@
-#include "common.h"
+#include "game/gamework_data.h"
 #include "dolphin.h"
 #include "REL/executor.h"
 #include "game/process.h"
+#include "game/window.h"
+#include "board_unsplit.h"
+#include "unsplit.h"
 
 #define ARRAY_COUNT(arr) (s32)(sizeof(arr) / sizeof(arr[0]))
 
@@ -27,11 +30,6 @@ typedef struct w10DllUnk01 {
     f32 unk10;
 } w10DllUnk01; //sizeof ?
 
-typedef struct m456DllUnk02 {
-    char unk00[0x5C];
-    w10DllUnk01* unk5C;
-} m456DllUnk02; //sizeof ?
-
 typedef struct w10DllUnk03 {
     s16 unk0;
     s16 unk2;

include/board_unsplit.h

@@ -1,49 +1,7 @@
-#ifndef _FUNCTIONS_H_
+#ifndef _UNSPLIT_BOARD_H
-#define _FUNCTIONS_H_
+#define _UNSPLIT_BOARD_H
 
 #include "dolphin.h"
-#include "common_structs.h"
-
-void Hu3DLayerHookSet(short layer, void (*func)(short layer));
-void Hu3D2Dto3D(Vec*, s32, Vec*);
-void Hu3DBGColorSet(u8, u8, u8);
-void Hu3DCameraCreate(s32);
-void Hu3DCameraPerspectiveSet(s32, f32, f32, f32, f32);
-void Hu3DCameraViewportSet(s32, f32, f32, f32, f32, f32, f32);
-void HuAudFadeOut(s32 arg0);
-
-void Hu3DModelPosSet(s16 index, float x, float y, float z);
-void Hu3DModelRotSet(s16 index, float x, float y, float z);
-void Hu3DModelScaleSet(s16 index, float x, float y, float z);
-
-void espInit(void);
-void espScaleSet(s16, f32, f32);
-s16 espEntry(s32, s32, s32);
-void espDispOff(s16);
-void espKill(s16);
-void espDispOn(s16);
-void espPosSet(s16, f32, f32);
-
-void HuWinAllKill(void);
-void HuWinKill(s16);
-void HuWinPriSet(s16, s16);
-void HuWinHomeClear(s16);
-void HuWinMesPalSet(s16, u8, u8, u8, u8);
-void HuWinMesSet(s16, u32);
-void HuWinMesSpeedSet(s16, s16);
-void HuWinMesMaxSizeGet(s16, f32*, ...);
-s16 HuWinCreate(float x, float y, s16 w, s16 h, s16 frame);
-
-void HuAudFXListnerKill(void);
-void HuAudDllSndGrpSet(u16 ovl);
-void HuAudVoiceInit(s16 ovl);
-
-void MGSeqKillAll(void);
-
-void MGSeqPracticeStart(void);
-void fn_8004D6F4(s16 arg);
-
-s32 rand8(void);
 
 void BoardCameraTargetModelSet(s16 model); 
 void BoardCameraMotionStartEx(s16, Vec *, Vec *, f32, f32, s16); 

include/common.h

@@ -1,9 +0,0 @@
-#ifndef _COMMON_H_
-#define _COMMON_H_
-
-#include "types.h"
-#include "common_structs.h"
-#include "functions.h"
-#include "variables.h"
-
-#endif

include/game/armem.h

@@ -1,7 +1,7 @@
 #ifndef _GAME_ARMEM_H
 #define _GAME_ARMEM_H
 
-#include "common.h"
+#include "dolphin.h"
 #include "game/memory.h"
 #include "game/data.h"
 

include/game/audio.h

@@ -1,7 +1,7 @@
 #ifndef _GAME_AUDIO_H
 #define _GAME_AUDIO_H
 
-#include "common.h"
+#include "dolphin.h"
 
 void HuAudInit(void);
 s32 HuAudStreamPlay(void);
@@ -56,4 +56,6 @@ s32 HuAudCharVoicePlay(s16 arg0, s16 arg1);
 s32 HuAudCharVoicePlayPos(s16 arg0, s16 arg1, Vec *arg2);
 void HuAudCharVoicePlayEntry(s16 arg0, s16 arg1);
 
+extern u8 fadeStat;
+
 #endif

include/game/board/basic_space.h

@@ -1,11 +1,8 @@
 #ifndef _BOARD_BASIC_SPACE_H
 #define _BOARD_BASIC_SPACE_H
 
-#include "common.h"
+#include "dolphin.h"
-#include "math.h"
 #include "game/process.h"
-#include "game/audio.h"
-#include "game/object.h"
 
 extern Process *boardObjMan;
 

include/game/board/warp.h

@@ -1,7 +1,8 @@
-#include "common.h"
+#ifndef _BOARD_WARP_H
+#define _BOARD_WARP_H
+
 #include "game/process.h"
 #include "game/wipe.h"
-#include "math.h"
 
 void fn_80080D54(s32);
 void fn_80080DF8(void);
@@ -11,3 +12,5 @@ void fn_800811BC(s32);
 void fn_80081278(s32);
 void fn_80081428(s32);
 void fn_800814CC(s32);
+
+#endif

include/game/board/window.h

@@ -1,10 +1,8 @@
 #ifndef _BOARD_WINDOW_H
 #define _BOARD_WINDOW_H
 
-#include "common.h"
 #include "game/window.h"
 #include "game/process.h"
-#include "game/gamework.h"
 
 typedef void (*BoardWinComKeyFunc)();
 

include/game/data.h

@@ -63,5 +63,6 @@ void *HuDataReadNumHeapShortForce(s32 data_id, s32 num, HeapID heap);
 
 void HuDecodeData(void *src, void *dst, u32 size, int decode_type);
 
+extern u32 DirDataSize;
 
 #endif

include/game/gamework_data.h

@@ -1,7 +1,6 @@
-#ifndef _COMMON_STRUCTS_H
+#ifndef _GAMEWORK_DATA_H
-#define _COMMON_STRUCTS_H
+#define _GAMEWORK_DATA_H
 
-#include "types.h"
 #include "dolphin.h"
 
 typedef struct player_config {
@@ -143,4 +142,9 @@ typedef struct game_stat {
     };
 } GameStat;
 
+extern PlayerConfig GWPlayerCfg[4];
+extern PlayerState GWPlayer[4];
+extern SystemState GWSystem;
+extern GameStat GWGameStat;
+
 #endif

include/game/hsfanim.h

@@ -1,7 +1,6 @@
 #ifndef GAME_HSFANIM_H
 #define GAME_HSFANIM_H
 
-#include "common.h"
 #include "game/hsfformat.h"
 #include "game/hsfman.h"
 #include "game/sprite.h"

include/game/hsfman.h

@@ -1,7 +1,6 @@
 #ifndef _GAME_HSFMAN_H
 #define _GAME_HSFMAN_H
 
-#include "common.h"
 #include "math.h"
 #include "game/memory.h"
 #include "game/hsfanim.h"
@@ -283,6 +282,7 @@ extern MotionData Hu3DMotion[0x100];
 extern u32 totalMatCnt;
 extern u32 totalMatCnted;
 extern u32 totalPolyCnt;
+extern u32 totalPolyCnted;
 extern u32 totalTexCacheCnt;
 extern u32 totalTexCacheCnted;
 extern u32 totalTexCnt;

include/game/msm.h

@@ -1,7 +1,7 @@
 #ifndef _GAME_MSM_H
 #define _GAME_MSM_H
 
-#include "common.h"
+#include "dolphin.h"
 
 typedef struct {
     s32 unk00;

include/game/saveload.h

@@ -1,7 +1,7 @@
 #ifndef _GAME_SAVELOAD_H
 #define _GAME_SAVELOAD_H
 
-#include "common.h"
+#include "dolphin.h"
 
 s32 SLFileOpen(char *arg0);
 s32 SLFileCreate(char *arg0, u32 arg1, void *arg2);

include/unsplit.h

@@ -0,0 +1,30 @@
+#ifndef _UNSPLIT_H
+#define _UNSPLIT_H
+
+#include "dolphin.h"
+
+void Hu3D2Dto3D(Vec*, s32, Vec*);
+void HuAudFadeOut(s32 arg0);
+
+void Hu3DModelPosSet(s16 index, float x, float y, float z);
+void Hu3DModelRotSet(s16 index, float x, float y, float z);
+void Hu3DModelScaleSet(s16 index, float x, float y, float z);
+
+void espInit(void);
+void espScaleSet(s16, f32, f32);
+s16 espEntry(s32, s32, s32);
+void espDispOff(s16);
+void espKill(s16);
+void espDispOn(s16);
+void espPosSet(s16, f32, f32);
+
+void HuAudFXListnerKill(void);
+void HuAudDllSndGrpSet(u16 ovl);
+void HuAudVoiceInit(s16 ovl);
+
+void MGSeqKillAll(void);
+
+void MGSeqPracticeStart(void);
+void fn_8004D6F4(s16 arg);
+
+#endif

include/variables.h

@@ -1,20 +0,0 @@
-#ifndef _VARIABLES_H
-#define _VARIABLES_H
-
-#include "dolphin.h"
-#include "common_structs.h"
-
-
-extern PlayerConfig GWPlayerCfg[4];
-
-
-extern u32 DirDataSize;
-
-extern u32 totalPolyCnted;
-extern u8 fadeStat;
-
-extern PlayerState GWPlayer[4];
-extern SystemState GWSystem;
-extern GameStat GWGameStat;
-
-#endif

src/REL/_minigameDLL/_minigameDLL.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "REL/executor.h"
 #include "dolphin/os.h"
 

src/REL/bootDll/nintendo_data.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/data.h"
 
 #include "logoNintendoData.inc"

src/game/audio.c

@@ -3,7 +3,7 @@
 #include "game/msm.h"
 #include "game/object.h"
 #include "game/wipe.h"
-
+#include "game/gamework_data.h"
 
 typedef struct {
     /* 0x00 */ s16 unk00;

src/game/board/basic_space.c

@@ -1,7 +1,9 @@
 #include "game/board/basic_space.h"
 #include "game/data.h"
 #include "game/flag.h"
-
+#include "game/object.h"
+#include "game/gamework_data.h"
+#include "board_unsplit.h"
 #include "math.h"
 
 typedef struct bit_copy {

src/game/board/warp.c

@@ -1,4 +1,7 @@
 #include "game/board/warp.h"
+#include "game/gamework_data.h"
+#include "board_unsplit.h"
+#include "math.h"
 
 extern void omVibrate(s16, s16, s16, s16);
 extern void fn_800816CC(s32, s32);

src/game/board/window.c

@@ -1,4 +1,5 @@
 #include "game/board/window.h"
+#include "game/gamework_data.h"
 
 extern s32 BoardPlayerIsAllCom(void);
 extern Process* boardMainProc;

src/game/data.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/data.h"
 #include "game/armem.h"
 #include "dolphin/dvd.h"

src/game/decode.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/data.h"
 #include "dolphin/os.h"
 

src/game/dvd.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/dvd.h"
 #include "game/data.h"
 

src/game/flag.c

@@ -1,4 +1,5 @@
-#include "common.h"
+#include "dolphin.h"
+#include "game/gamework_data.h"
 
 static u8 _Sys_Flag[16];
 

src/game/frand.c

@@ -1,4 +1,4 @@
-#include "common.h"
+#include "dolphin.h"
 
 static u32 frand_seed;
 

src/game/gamework.c

@@ -1,6 +1,6 @@
-#include "common.h"
 #include "string.h"
 #include "game/gamework.h"
+#include "game/gamework_data.h"
 #include "game/flag.h"
 
 GameStat GWGameStatDefault;

src/game/init.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/init.h"
 #include "dolphin/os.h"
 #include "dolphin/gx.h"

src/game/main.c

@@ -1,4 +1,4 @@
-#include "common.h"
+#include "game/gamework_data.h"
 #include "game/dvd.h"
 #include "game/printfunc.h"
 #include "game/object.h"

src/game/malloc.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/memory.h"
 #include "game/init.h"
 #include "dolphin/os.h"

src/game/memory.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/memory.h"
 #include "dolphin/os.h"
 

src/game/messdata.c

@@ -1,4 +1,4 @@
-#include "common.h"
+#include "dolphin.h"
 
 static void *MessData_MesDataGet(void *messdata, u32 id)
 {

src/game/objmain.c

@@ -1,4 +1,5 @@
-#include "common.h"
+#include "game/audio.h"
+#include "game/hsfman.h"
 #include "game/printfunc.h"
 #include "game/object.h"
 #include "game/pad.h"

src/game/ovllist.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/dvd.h"
 #include "game/object.h"
 

src/game/pad.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "dolphin.h"
 #include "game/msm.h"
 #include "game/pad.h"

src/game/printfunc.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "dolphin.h"
 #include "game/printfunc.h"
 #include "game/init.h"

src/game/process.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/process.h"
 #include "game/memory.h"
 #include "dolphin/os.h"

src/game/saveload.c

@@ -4,6 +4,7 @@
 #include "game/window.h"
 #include "game/flag.h"
 #include "game/card.h"
+#include "game/gamework_data.h"
 
 #include "string.h"
 

src/game/sprman.c

@@ -1,4 +1,3 @@
-#include "common.h"
 #include "game/sprite.h"
 #include "game/memory.h"
 #include "game/init.h"

src/game/sprput.c

@@ -1,5 +1,5 @@
-#include "common.h"
 #include "game/sprite.h"
+#include "game/hsfman.h"
 #include "game/init.h"
 #include "dolphin/mtx.h"
 #include "dolphin/gx.h"

src/game/window.c

@@ -1,4 +1,4 @@
-#include "common.h"
+#include "game/gamework_data.h"
 
 #include "game/window.h"
 #include "game/sprite.h"